Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit test of DefaultMQProducer has some problems when send async messages #1528

Closed
keranbingaa opened this issue Oct 15, 2019 · 1 comment
Labels
Milestone

Comments

@keranbingaa
Copy link
Contributor

@keranbingaa keranbingaa commented Oct 15, 2019

BUG REPORT

  1. Please describe the issue you observed:
    in DefaultMQProducerTest, the async mode test doesn't execute as expected.
    For example, the testSendMessageAsync_Success function call send function, which is expected to excute callback function onSuccess, but when I debug, I find it calls onException.

  2. Please tell us about your environment:
    rocketMQ 4.5

  3. Other information (e.g. detailed explanation, logs, related issues, suggestions how to fix, etc):
    when producer get the topicrouteinfo, it returns null, which causes this problem. So if the producer get right topicrouteinfo and call sendback function, it canbe excuted as we expected.

@duhenglucky duhenglucky added this to the 4.7.0 milestone Oct 18, 2019
duhenglucky added a commit that referenced this issue Oct 23, 2019
[ISSUE #1528] mocking related functions to make producer get right topicrouteinfo and invoke callback functions
@duhenglucky

This comment has been minimized.

Copy link
Contributor

@duhenglucky duhenglucky commented Oct 23, 2019

merged, thanks for your contribution.

duhenglucky added a commit that referenced this issue Oct 24, 2019
[ISSUE #1528]bug fix for unit tests of DefaultMQProducer
duhenglucky added a commit that referenced this issue Nov 14, 2019
[ISSUE #1528]modify unit test of producer
@duhenglucky duhenglucky modified the milestones: 4.7.0, 4.6.0 Nov 14, 2019
duhenglucky added a commit that referenced this issue Nov 18, 2019
* modify testSendMessageAsync_Success

* revert testSendMessageAsync_Success
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.