Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark stream-related request by RequestType #3906

Closed
drpmma opened this issue Mar 1, 2022 · 3 comments
Closed

Mark stream-related request by RequestType #3906

drpmma opened this issue Mar 1, 2022 · 3 comments

Comments

@drpmma
Copy link
Contributor

drpmma commented Mar 1, 2022

  1. Plan to add a RequestType in remoting protocol to indicate stream requests including requests driven by PullConsumer and LitePullConsumer.
  2. Stream is an important part of rocketmq and it is not marked and distinguished with the messaging-related requests by now. It is helpful for observability and other features to mark it explicitly
@ni-ze
Copy link
Contributor

ni-ze commented Mar 2, 2022

I am sorry, I think we can put a key value pair in properties of Message, then we know what business the message comes from. Adding business attributes into remote protocol is not recommended.

@lizhanhui
Copy link
Contributor

@drpmma Would you mind offering your use case story? Looks you and @ni-ze are talking about two completely different things.

@drpmma
Copy link
Contributor Author

drpmma commented Mar 8, 2022

Stream is a totally different scenario compared with messaging. As I know, Many companies in industries develop rocketmq proxy to manage and distribute traffic. It is helpful to mark stream requests explicitly for traffic management and scalability like proxy scenarios.

drpmma added a commit to drpmma/rocketmq that referenced this issue Jun 6, 2022
drpmma added a commit to drpmma/rocketmq that referenced this issue Jun 6, 2022
drpmma added a commit to drpmma/rocketmq that referenced this issue Jun 7, 2022
drpmma added a commit to drpmma/rocketmq that referenced this issue Jun 7, 2022
drpmma added a commit to drpmma/rocketmq that referenced this issue Jun 7, 2022
drpmma added a commit to drpmma/rocketmq that referenced this issue Jun 8, 2022
zhouxinyu pushed a commit that referenced this issue Jun 20, 2022
drpmma added a commit to drpmma/rocketmq that referenced this issue Jun 20, 2022
drpmma added a commit to drpmma/rocketmq that referenced this issue Jun 20, 2022
drpmma added a commit to drpmma/rocketmq that referenced this issue Jun 20, 2022
drpmma added a commit to drpmma/rocketmq that referenced this issue Jun 20, 2022
drpmma added a commit to drpmma/rocketmq that referenced this issue Jul 13, 2022
drpmma added a commit to drpmma/rocketmq that referenced this issue Jul 13, 2022
drpmma added a commit to drpmma/rocketmq that referenced this issue Jul 13, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this issue Aug 12, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this issue Aug 12, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this issue Aug 12, 2022
@drpmma drpmma closed this as completed Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants