New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 代码是否merge丢了 #408

Closed
chixuan777 opened this Issue Aug 13, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@chixuan777

chixuan777 commented Aug 13, 2018

d8c446e

    if (this.transactionalMessageCheckService != null) {
        this.transactionalMessageCheckService.shutdown(false);
    }

这部分代码删除了
是否必须删除?

@duhengforever

This comment has been minimized.

Show comment
Hide comment
@duhengforever

duhengforever Aug 13, 2018

Member

@chixuan777 I checked the code, it should be a mistake when resolve the conflict during merge process, welcome to pull a request, we will merge ASAP.

Member

duhengforever commented Aug 13, 2018

@chixuan777 I checked the code, it should be a mistake when resolve the conflict during merge process, welcome to pull a request, we will merge ASAP.

@chixuan777

This comment has been minimized.

Show comment
Hide comment
@chixuan777

chixuan777 commented Aug 13, 2018

@duhengforever here is the PR
#410

@vongosling vongosling closed this Aug 21, 2018

@vongosling vongosling added the bug label Aug 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment