Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify exception declaration #1225

Merged
merged 11 commits into from Jun 14, 2019

Conversation

@xlzl
Copy link

xlzl commented May 23, 2019

modify "TimeDelayLevel in not supported for batching"

What is the purpose of the change

modify an exception declaration

Brief changelog

"TimeDelayLevel in not supported for batching" -> "TimeDelayLevel is not supported for batching"

Verifying this change

nothing

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.
vongosling and others added 11 commits Jan 10, 2019
[RIP-9] Commit docs Example_OpenMessaging.md
周浪
modify "TimeDelayLevel in not supported for batching"
@vongosling vongosling changed the base branch from master to develop Jun 14, 2019
@vongosling vongosling changed the title modify exception declaration Modify exception declaration Jun 14, 2019
@vongosling vongosling added this to the 4.5.2 milestone Jun 14, 2019
@vongosling vongosling merged commit a7e77d2 into apache:develop Jun 14, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.