Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RIP-9]Fix some description in document of rocketmq #1232

Merged
merged 1 commit into from Jun 13, 2019

Conversation

@ZhangChaoWN
Copy link
Contributor

ZhangChaoWN commented May 27, 2019

What is the purpose of the change

fix typo

Brief changelog

fix two typo

Verifying this change

no need to verifying for doc changes

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.
@coveralls

This comment has been minimized.

Copy link

coveralls commented May 29, 2019

Coverage Status

Coverage decreased (-0.1%) to 50.528% when pulling 2b97fb7 on ZhangChaoWN:master into 40c255d on apache:master.

@ShannonDing

This comment has been minimized.

Copy link
Member

ShannonDing commented Jun 13, 2019

Could you please change this PR to develop branch?

@ZhangChaoWN ZhangChaoWN changed the base branch from master to develop Jun 13, 2019
@ZhangChaoWN

This comment has been minimized.

Copy link
Contributor Author

ZhangChaoWN commented Jun 13, 2019

Could you please change this PR to develop branch?

changed

Copy link
Member

ShannonDing left a comment

LGTM

@ShannonDing ShannonDing added this to the 4.5.2 milestone Jun 13, 2019
@ShannonDing ShannonDing added the doc label Jun 13, 2019
@ShannonDing ShannonDing merged commit e9bc366 into apache:develop Jun 13, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@zongtanghu zongtanghu changed the title fix typo [RIP-9]fix some Jul 12, 2019
@zongtanghu zongtanghu changed the title [RIP-9]fix some [RIP-9]fix some description in document of rocketmq Jul 12, 2019
@zongtanghu zongtanghu changed the title [RIP-9]fix some description in document of rocketmq [RIP-9]Fix some description in document of rocketmq Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.