Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #1308] Fix some spelling errors of method names. #1307

Merged
merged 5 commits into from Jul 15, 2019

Conversation

@ak47plusplus
Copy link
Contributor

ak47plusplus commented Jul 7, 2019

What is the purpose of the change

#1308
Fix some spelling errors of method names in file named 'UtilAll.java'

These changes seem trivial, but it's an international project and I think the right naming helps other developers understand it.

Brief changelog

the UtilAll.computeEclipseTimeMilliseconds was modified to UtilAll.computeElapsedTimeMilliseconds
(I think this method is to calculate the elapsed time by giving the start time.)

'computNextMorningTimeMillis' was modified to 'computeNextMorningTimeMillis '

'computNextHourTimeMillis' was modified to 'computeNextHourTimeMillis '

'computNextMinutesTimeMillis' was modified to 'computeNextMinutesTimeMillis '

'computNextHalfHourTimeMillis' was modified to 'computeNextHalfHourTimeMillis '

Verifying this change

Nothing.

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.
@ak47plusplus ak47plusplus reopened this Jul 7, 2019
@ak47plusplus ak47plusplus changed the title Fix some spelling errors of method names. [ISSUE #1308] Fix some spelling errors of method names. Jul 8, 2019
@ak47plusplus ak47plusplus reopened this Jul 8, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 8, 2019

Coverage Status

Coverage increased (+0.03%) to 50.49% when pulling 4ff5462 on kinoko1996:develop into d66243c on apache:develop.

@ak47plusplus ak47plusplus reopened this Jul 9, 2019
@ak47plusplus

This comment has been minimized.

Copy link
Contributor Author

ak47plusplus commented Jul 9, 2019

@zongtanghu hi !Could u help me with this PR in your busy schedule ?

@ShannonDing ShannonDing added the bug label Jul 10, 2019
Copy link
Member

ShannonDing left a comment

LGTM

@liuruiyiyang

This comment has been minimized.

Copy link
Contributor

liuruiyiyang commented Jul 15, 2019

@kinoko1996
If you could rename the computPullFromWhichFilterServer method in PullAPIWrapper to computePullFromWhichFilterServer by the way, then all the "comput" misspell will be fixed.
Thank you :)

@vongosling vongosling added enhancement and removed bug labels Jul 15, 2019
@vongosling vongosling added this to the 4.5.2 milestone Jul 15, 2019
@vongosling vongosling merged commit be7c6dd into apache:develop Jul 15, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 50.49%
Details
@ak47plusplus

This comment has been minimized.

Copy link
Contributor Author

ak47plusplus commented Jul 15, 2019

@kinoko1996
If you could rename the computPullFromWhichFilterServer method in PullAPIWrapper to computePullFromWhichFilterServer by the way, then all the "comput" misspell will be fixed.
Thank you :)

I'd love to do that. But this PR is merged, and I need to propose an additional Pr to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.