Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1315]Add RPCHook construct method for MQPullConsumerScheduleService #1314

Merged
merged 1 commit into from Jul 11, 2019

Conversation

@duhenglucky
Copy link
Contributor

duhenglucky commented Jul 11, 2019

What is the purpose of the change

Current, MQPullConsumerScheduleService has no ways to inject a custom RPCHook, this PR add RPCHook construct method for MQPullConsumerScheduleService, used to set an RPChook when creating this service.

Brief changelog

Add RPCHook construct method for MQPullConsumerScheduleService

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.
@duhenglucky duhenglucky changed the title Add RPCHook construct method for MQPullConsumerScheduleService [#1315]Add RPCHook construct method for MQPullConsumerScheduleService Jul 11, 2019
@duhenglucky duhenglucky added this to the 4.5.2 milestone Jul 11, 2019
@zongtanghu

This comment has been minimized.

Copy link
Contributor

zongtanghu commented Jul 11, 2019

LGTM

@vongosling vongosling merged commit c40cdf0 into apache:develop Jul 11, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 11, 2019

Coverage Status

Coverage increased (+0.01%) to 50.531% when pulling 75d8bb3 on duhenglucky:SchedualPullPolish into 9226292 on apache:develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.