Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #1344] Fix /dev/shm not found on some OS #1345

Merged
merged 1 commit into from Jul 30, 2019

Conversation

@liuruiyiyang
Copy link
Contributor

liuruiyiyang commented Jul 28, 2019

What is the purpose of the change

Fix issue #1344

Brief changelog

  1. If the current OS is Darwin, create RAMDisk as the substitute for /dev/shm to store gc log. On other systems, check if /dev/shm exists. If /dev/shm does not exist, store gc log in ${BASE_DIR}.

  2. Correct and unify the gc log file name.

  3. Use UseGCLogFileRotation in runserver.sh because name service is also a long-lived service process

modified: distribution/benchmark/runclass.sh
modified: distribution/bin/runbroker.sh
modified: distribution/bin/runserver.sh

Verifying this change

Start the name service and broker on the MacOS and Linux Systems

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 28, 2019

Coverage Status

Coverage decreased (-0.003%) to 50.54% when pulling 37ad96c on liuruiyiyang:polish_startup_scripts into e1b9a32 on apache:develop.

@liuruiyiyang

This comment has been minimized.

Copy link
Contributor Author

liuruiyiyang commented Jul 29, 2019

distribution/benchmark/runclass.sh Outdated Show resolved Hide resolved
@vongosling vongosling added this to the 4.6.0 milestone Jul 29, 2019
@ShannonDing ShannonDing modified the milestones: 4.6.0, 4.5.2 Jul 30, 2019
@ShannonDing ShannonDing merged commit 7ac5ad3 into apache:develop Jul 30, 2019
1 of 2 checks passed
1 of 2 checks passed
coverage/coveralls Coverage decreased (-0.003%) to 50.54%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zongtanghu zongtanghu changed the title [ISSUE #1344] Fix /dev/shm not found on some OSs [ISSUE #1344] Fix /dev/shm not found on some OS Aug 2, 2019
supercym pushed a commit to supercym/rocketmq that referenced this pull request Aug 22, 2019
duhenglucky added a commit that referenced this pull request Aug 22, 2019
* Remove the useless files

* Replace PermSize with MetaspaceSize, details see http://openjdk.java.net/jeps/122

* Update DLedgerCommitLog.java (#1145)

Delete useless code

* Remove the duplicate content

* Polish the comment (#1107)

* Minor Typo fix  (#860)

* [ISSUE #1082] Fix disconnection of HA (#1083)

* fixed the text description in chinese doc (#1339)

* fix /dev/shm not found on some OSs (#1345)

* Refactor the protection logic when pulling

* change the MQVersion variable to rocketmq 4.5.2 version;

* Minor polish

* Fix the wrong package name

* [maven-release-plugin] prepare release rocketmq-all-4.5.2

* [maven-release-plugin] prepare for next development iteration

* [RIP-15]Add Ipv6 support for RocketMQ
@duhenglucky duhenglucky mentioned this pull request Aug 22, 2019
5 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.