Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(formatting): minor polish #1420

Merged
merged 1 commit into from Aug 28, 2019

Conversation

@zzkyeee
Copy link
Contributor

zzkyeee commented Aug 27, 2019

1.remove end of line comment 2.add override annotation when rewrite method

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 27, 2019

Coverage Status

Coverage increased (+0.1%) to 50.698% when pulling e251828 on zzkyeee:master into 2c414fa on apache:master.

@vongosling vongosling added this to the 4.6.0 milestone Aug 28, 2019
@vongosling vongosling merged commit 83de262 into apache:master Aug 28, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 50.698%
Details
vongosling added a commit that referenced this pull request Aug 28, 2019
…ewrite method (#1420)"

This reverts commit 83de262.
vongosling added a commit that referenced this pull request Aug 28, 2019
…ewrite method (#1420)" (#1423)

This reverts commit 83de262.
liuruiyiyang added a commit to liuruiyiyang/rocketmq that referenced this pull request Sep 16, 2019
liuruiyiyang added a commit to liuruiyiyang/rocketmq that referenced this pull request Sep 16, 2019
@vongosling vongosling changed the title Fix some typo style(formatting): minor polish Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.