Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guide): polish definite article and indefinite article usage #1438

Merged
merged 22 commits into from Sep 17, 2019

Conversation

@KangZhiDong
Copy link
Contributor

KangZhiDong commented Aug 31, 2019

No description provided.

vongosling and others added 20 commits Jan 10, 2019
[RIP-9] Commit docs Example_OpenMessaging.md
Add Export Control Notice
## 3 消息过滤
…ewrite method (#1420)" (#1423)

This reverts commit 83de262.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 31, 2019

Coverage Status

Coverage decreased (-0.1%) to 49.507% when pulling 02b5121 on KangZhiDong:master into 74ffae6 on apache:develop.

@ShannonDing

This comment has been minimized.

Copy link
Member

ShannonDing commented Sep 2, 2019

Plz move this PR to develop branch.

@KangZhiDong KangZhiDong changed the base branch from master to develop Sep 2, 2019
@@ -25,7 +25,7 @@ export NAMESRV_ADDR=192.168.0.1:9876;192.168.0.2:9876
```
- HTTP static server addressing(default)

After client started, it will access a http static server address, as: <http://jmenv.tbsite.net:8080/rocketmq/nsaddr>, this URL return the following contents:
After client started, it will access an http static server address, as: <http://jmenv.tbsite.net:8080/rocketmq/nsaddr>, this URL return the following contents:

This comment has been minimized.

Copy link
@ShannonDing

ShannonDing Sep 2, 2019

Member

Why not use "an" here?

This comment has been minimized.

Copy link
@KangZhiDong

KangZhiDong Sep 2, 2019

Author Contributor

an http

@duhenglucky

This comment has been minimized.

Copy link
Contributor

duhenglucky commented Sep 11, 2019

@KangZhiDong please rebase first, this pr brought so many other commits.

@KangZhiDong

This comment has been minimized.

Copy link
Contributor Author

KangZhiDong commented Sep 11, 2019

@KangZhiDong please rebase first, this pr brought so many other commits.

get .

@vongosling vongosling merged commit d71495a into apache:develop Sep 17, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@vongosling vongosling added this to the 4.6.0 milestone Sep 17, 2019
@vongosling vongosling changed the title fix typo Polish definite article and indefinite article usage Sep 17, 2019
@vongosling vongosling changed the title Polish definite article and indefinite article usage docs(guide): polish definite article and indefinite article usage Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.