New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rocketmq-285] file test error when make link #154

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
5 participants
@zwillim
Contributor

zwillim commented Aug 25, 2017

line 62.
cannot test ${HOME}/tmpfs while making link to ./tmpfs
change "ln -s /dev/shm tmpfs" to "ln -s /dev/shm ${HOME}/tmpfs"

https://issues.apache.org/jira/browse/ROCKETMQ-285

logistic error
line 62.
cannot test ${HOME}/tmpfs while making link to ./tmpfs
change "ln -s /dev/shm tmpfs" to "ln -s /dev/shm ${HOME}/tmpfs"
@coveralls

This comment has been minimized.

coveralls commented Aug 25, 2017

Coverage Status

Coverage increased (+0.03%) to 38.808% when pulling 00d0fb6 on zwillim:patch-1 into 2ddb744 on apache:master.

1 similar comment
@coveralls

This comment has been minimized.

coveralls commented Aug 25, 2017

Coverage Status

Coverage increased (+0.03%) to 38.808% when pulling 00d0fb6 on zwillim:patch-1 into 2ddb744 on apache:master.

@Jaskey

This comment has been minimized.

Contributor

Jaskey commented Aug 29, 2017

Please link the jira in the description and modify the title accordingly.

@zwillim zwillim changed the title from logistic error to file test error when make link Sep 4, 2017

@zwillim

This comment has been minimized.

Contributor

zwillim commented Sep 4, 2017

modified as required.

@zwillim zwillim closed this Sep 4, 2017

@zwillim zwillim reopened this Sep 4, 2017

@coveralls

This comment has been minimized.

coveralls commented Sep 4, 2017

Coverage Status

Coverage decreased (-0.06%) to 38.712% when pulling 00d0fb6 on zwillim:patch-1 into 2ddb744 on apache:master.

@shroman

shroman approved these changes Sep 4, 2017

@shroman

This comment has been minimized.

Contributor

shroman commented Sep 4, 2017

The title should be "[Rocketmq-285] file test error when make link"

@zwillim zwillim changed the title from file test error when make link to [Rocketmq-285] file test error when make link Sep 4, 2017

@zwillim

This comment has been minimized.

Contributor

zwillim commented Sep 4, 2017

title modified

@dongeforever

This comment has been minimized.

Member

dongeforever commented Sep 20, 2017

@zwillim I want to merge this PR. Could you please change the target branch to apache:develop ?
As all the PRs are merged into develop at first.

@zwillim zwillim changed the base branch from master to develop Sep 21, 2017

@zwillim

This comment has been minimized.

Contributor

zwillim commented Sep 21, 2017

changed as needed.

asfgit pushed a commit that referenced this pull request Sep 22, 2017

[ROCKETMQ-285] file test error when make link
Author: willim.z <zwillim@gmail.com>

Closes #154 from zwillim/patch-1.
@dongeforever

This comment has been minimized.

Member

dongeforever commented Sep 22, 2017

@zwillim This PR has been merged. Could you please help close this PR?

@zwillim

This comment has been minimized.

Contributor

zwillim commented Sep 23, 2017

@zwillim zwillim closed this Sep 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment