New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #1561]Support specify max reconsume times in message level #1562
[ISSUE #1561]Support specify max reconsume times in message level #1562
Conversation
你好,你这个修改,只修改了并行消费模式的最大重试次数。。我觉得既然是个消息级别的设置,那么应该在各种消费模式下都能起作用。 我尝试写了一版功能,你能帮我Review一下吗?PR1570 |
@YuShanMuGong Yes, this is only effective for concurrently service, since it is most popular. For orderly consume service, it may be different since it does not redeliever so it is not included in this pr |
9f2ee75
to
6c019c4
Compare
@duhenglucky would you please help to review this pr? |
Codecov Report
@@ Coverage Diff @@
## develop #1562 +/- ##
=============================================
+ Coverage 45.42% 45.47% +0.04%
- Complexity 4242 4247 +5
=============================================
Files 545 545
Lines 35843 35850 +7
Branches 4762 4764 +2
=============================================
+ Hits 16283 16304 +21
+ Misses 17511 17494 -17
- Partials 2049 2052 +3 Continue to review full report at Codecov.
|
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. |
This PR was closed because it has been inactive for 3 days since being marked as stale. |
What is the purpose of the change
setting MAX_RECONSUME_TIMES in message has no effect to control max reconsume times, this pr is intending to fix this issue.
Since the retry strategy between consuming concurrently and consuming orderly, this pr is going to enhance concurrently only
Brief changelog
When user need to control max reconsume times for a specific message, user may set MAX_RECONSUME_TIMES in the message property, it should be effected. But currently, it is not, only max reconsume times in consumer level will be effected.