Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #1866] Fix transaction message doc #1867

Merged
merged 1 commit into from Mar 25, 2020

Conversation

9526xu
Copy link
Contributor

@9526xu 9526xu commented Mar 18, 2020

What is the purpose of the change

docs-cn and doc-en hash some error in transaction message.

Brief changelog

fix doc in :

AbstractTransactionCheckListener---->AbstractTransactionalMessageCheckListener

transactionMsgTimeout------>transactionTimeout

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 50.968% when pulling bebb4a8 on 9526xu:fix-transaction-doc into 8ef01a6 on apache:master.

@RongtongJin RongtongJin changed the title fix transaction message doc #1866 [ISSUE #1866] Fix transaction message doc Mar 23, 2020
@RongtongJin
Copy link
Contributor

Please change the target branch to develop.

@9526xu 9526xu changed the base branch from master to develop March 23, 2020 15:35
@9526xu
Copy link
Contributor Author

9526xu commented Mar 23, 2020

Please change the target branch to develop.

ok

@RongtongJin RongtongJin merged commit 549f72f into apache:develop Mar 25, 2020
@ShannonDing ShannonDing added this to the 4.7.1 milestone Apr 1, 2020
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
pulllock pushed a commit to pulllock/rocketmq that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants