Skip to content

[ISSUE #2072] Implement DefaultMQAdminExt::examineSubscriptionGroupConfig function #3353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
haozhijie9527 wants to merge 2 commits into from
Closed

[ISSUE #2072] Implement DefaultMQAdminExt::examineSubscriptionGroupConfig function #3353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
384eb9c
Implement DefaultMQAdminExt::examineSubscriptionGroupConfig function
Sep 14, 2021
e4e0928
throw MQBrokerException when subscriptionGroupConfig is not found
Sep 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tools/src/main/java/org/apache/rocketmq/tools/admin/DefaultMQAdminExt.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,9 @@ public void createAndUpdateSubscriptionGroupConfig(String addr,
}

@Override
public SubscriptionGroupConfig examineSubscriptionGroupConfig(String addr, String group) {
public SubscriptionGroupConfig examineSubscriptionGroupConfig(String addr, String group)
throws InterruptedException, RemotingConnectException, RemotingTimeoutException,
RemotingSendRequestException, MQBrokerException {
return defaultMQAdminExtImpl.examineSubscriptionGroupConfig(addr, group);
}

Expand Down
21 changes: 16 additions & 5 deletions tools/src/main/java/org/apache/rocketmq/tools/admin/DefaultMQAdminExtImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import java.util.Properties;
import java.util.Random;
import java.util.Set;

import org.apache.commons.lang3.StringUtils;
import org.apache.rocketmq.client.QueryResult;
import org.apache.rocketmq.client.admin.MQAdminExtInner;
Expand All @@ -37,20 +38,18 @@
import org.apache.rocketmq.client.impl.MQClientManager;
import org.apache.rocketmq.client.impl.factory.MQClientInstance;
import org.apache.rocketmq.client.log.ClientLogger;
import org.apache.rocketmq.common.AclConfig;
import org.apache.rocketmq.common.MixAll;
import org.apache.rocketmq.common.PlainAccessConfig;
import org.apache.rocketmq.common.ServiceState;
import org.apache.rocketmq.common.TopicConfig;
import org.apache.rocketmq.common.AclConfig;
import org.apache.rocketmq.common.UtilAll;
import org.apache.rocketmq.common.admin.ConsumeStats;
import org.apache.rocketmq.common.admin.OffsetWrapper;
import org.apache.rocketmq.common.admin.RollbackStats;
import org.apache.rocketmq.common.admin.TopicOffset;
import org.apache.rocketmq.common.admin.TopicStatsTable;
import org.apache.rocketmq.common.help.FAQUrl;
import org.apache.rocketmq.common.protocol.body.ClusterAclVersionInfo;
import org.apache.rocketmq.logging.InternalLogger;
import org.apache.rocketmq.common.message.MessageClientExt;
import org.apache.rocketmq.common.message.MessageConst;
import org.apache.rocketmq.common.message.MessageDecoder;
Expand All @@ -59,6 +58,7 @@
import org.apache.rocketmq.common.namesrv.NamesrvUtil;
import org.apache.rocketmq.common.protocol.ResponseCode;
import org.apache.rocketmq.common.protocol.body.BrokerStatsData;
import org.apache.rocketmq.common.protocol.body.ClusterAclVersionInfo;
import org.apache.rocketmq.common.protocol.body.ClusterInfo;
import org.apache.rocketmq.common.protocol.body.ConsumeMessageDirectlyResult;
import org.apache.rocketmq.common.protocol.body.ConsumeStatsList;
Expand All @@ -78,6 +78,7 @@
import org.apache.rocketmq.common.protocol.route.QueueData;
import org.apache.rocketmq.common.protocol.route.TopicRouteData;
import org.apache.rocketmq.common.subscription.SubscriptionGroupConfig;
import org.apache.rocketmq.logging.InternalLogger;
import org.apache.rocketmq.remoting.RPCHook;
import org.apache.rocketmq.remoting.common.RemotingHelper;
import org.apache.rocketmq.remoting.common.RemotingUtil;
Expand Down Expand Up @@ -217,8 +218,18 @@ public void createAndUpdateSubscriptionGroupConfig(String addr,
}

@Override
public SubscriptionGroupConfig examineSubscriptionGroupConfig(String addr, String group) {
return null;
public SubscriptionGroupConfig examineSubscriptionGroupConfig(String addr, String group)
throws InterruptedException, MQBrokerException, RemotingTimeoutException, RemotingSendRequestException,
RemotingConnectException, MQClientException {
SubscriptionGroupWrapper subscriptionGroupWrapper =
this.mqClientInstance.getMQClientAPIImpl().getAllSubscriptionGroup(addr, timeoutMillis);
SubscriptionGroupConfig config = subscriptionGroupWrapper.getSubscriptionGroupTable().get(group);
if (config == null) {
throw new MQBrokerException(ResponseCode.SUBSCRIPTION_GROUP_NOT_EXIST,
"subscription group not exist, " + group + " " + FAQUrl
.suggestTodo(FAQUrl.SUBSCRIPTION_GROUP_NOT_EXIST));
}
return config;
}

@Override
Expand Down
4 changes: 3 additions & 1 deletion tools/src/main/java/org/apache/rocketmq/tools/admin/MQAdminExt.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,9 @@ void createAndUpdateSubscriptionGroupConfig(final String addr,
final SubscriptionGroupConfig config) throws RemotingException,
MQBrokerException, InterruptedException, MQClientException;

SubscriptionGroupConfig examineSubscriptionGroupConfig(final String addr, final String group);
SubscriptionGroupConfig examineSubscriptionGroupConfig(final String addr, final String group)
throws InterruptedException, MQBrokerException, RemotingTimeoutException, RemotingSendRequestException,
RemotingConnectException, MQClientException;

TopicConfig examineTopicConfig(final String addr, final String topic);

Expand Down
7 changes: 7 additions & 0 deletions tools/src/test/java/org/apache/rocketmq/tools/admin/DefaultMQAdminExtTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,4 +406,11 @@ public void testGetAllSubscriptionGroup() throws InterruptedException, MQBrokerE
assertThat(subscriptionGroupWrapper.getSubscriptionGroupTable().get("Consumer-group-one").getGroupName()).isEqualTo("Consumer-group-one");
assertThat(subscriptionGroupWrapper.getSubscriptionGroupTable().get("Consumer-group-one").isConsumeBroadcastEnable()).isTrue();
}

@Test
public void testExamineSubscriptionGroupConfig() throws MQBrokerException, RemotingException, InterruptedException {
SubscriptionGroupConfig subscriptionGroupConfig = defaultMQAdminExt
.examineSubscriptionGroupConfig("127.0.0.1:10911", "Consumer-group-one");
assertThat(subscriptionGroupConfig.getGroupName().equals("Consumer-group-one"));
}
}