Skip to content

Feature/3676#3677

Closed
Stupid-Dird wants to merge 2 commits into
apache:developfrom
Stupid-Dird:feature/3676
Closed

Feature/3676#3677
Stupid-Dird wants to merge 2 commits into
apache:developfrom
Stupid-Dird:feature/3676

Conversation

@Stupid-Dird
Copy link
Copy Markdown

Make sure set the target branch to develop

What is the purpose of the change

Issues #3676: handle the hook after the request () is sent

  1. Use countdownlatch When await (), only onException () will countDown (), which will lead to timeout exceptions after successful transmission.

  2. Solve the problem that the onsuccess () method of the incoming requestcallback is not called after sending successfully

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

大聪明 added 2 commits December 28, 2021 22:20
1.使用CountDownLatch.await()时,只有onException()会countDown(),导致发送成功后还是会超时异常
2.解决传入的RequestCallBack的onSuccess()方法在发送成功后没有调用的问题
1.使用CountDownLatch.await()时,只有onException()会countDown(),导致发送成功后还是会超时异常
2.解决传入的RequestCallBack的onSuccess()方法在发送成功后没有调用的问题
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant