Skip to content

Conversation

@RongtongJin
Copy link
Contributor

…ster name and broker name

What is the purpose of the change

Fix bug issues#465, topic should be added to topicList instead of cluster name and broker name

Brief changelog

In RouteInfoManager.getSystemTopicList() method,
1.Remove the code which adds cluster name and broker name to topicList.
2.Add topic name to topicList.

Verifying this change

Verified this change by running RouteInfoManagerTest.testGetSystemTopicList() unit test

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 42.383% when pulling 80a98be on RongtongJin:master into a220364 on apache:master.

@vongosling
Copy link
Member

@RongtongJin Could you please to change your target commit to develop instead of master. Another, make some unit-test for the polish :-)

@RongtongJin
Copy link
Contributor Author

RongtongJin commented Sep 20, 2018

I think my understanding of systemTopicList is incorrect.
At the beginning, I thought that getSystemTopicList means getting all the topic names, then I read the code carefully yesterday and found RouteInfoManager.getAllTopicList() has done this. I traced the call chain of getSystemToplicList and found MQClientAPIImpl.getSystemTopicList() is the last method called, so RouteManagerInfo.getSystemTopicList() never be called? ? ?
At the same time, I found some systemTopic will be added in rocketmq.broker.topic.TopicConfigManager#TopicConfigManager() when the BrokerController is initialized, including the broker name and cluster name. So systemTopicList should include broker name and cluster name. The original code is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants