Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated: the header to show the tagline only when its available #99

Merged
merged 2 commits into from Jul 23, 2021

Conversation

ymaheshwari1
Copy link
Contributor

Added an if condition to check whether the weblog has a tagline defined or not and if there is a tagline present then only displaying the tagline.

Before:
Tagline is always displayed.
image

After:
Tagline is only displayed when its defined
image

If tagline is not present then nothing is displayed.
image

@mbien
Copy link
Member

mbien commented Jul 18, 2021

Hi Yash, have you checked if this can also happen with the other themes?

@ymaheshwari1
Copy link
Contributor Author

Hi @mbien I am checking other themes for the same.

@mbien
Copy link
Member

mbien commented Jul 23, 2021

lgtm, integrating

@mbien mbien merged commit 94ebf3b into apache:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants