SAMZA-41 changes with doc updates #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
This has been merged in Samza 0.10.1 release. @mdaxini can we close this PR? Thanks! |
|
@nickpan47 yes, closed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per my conversation with Yi Pan, I have attached the patch for SAMZA-41 built and tested against 0.9.1 branch, along with updated docs and unit tests.
The changes are pretty non-intrusive, and I am hoping this makes it into the 0.9.1 release.
Here is the review board link ([~nickpan47] I have added you as a reviewer. Please feel free to add others):
https://reviews.apache.org/r/35809/
I can send a separate pull request for master later on.