Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove link to ASF-wide security page from the menu #312

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

raboof
Copy link
Member

@raboof raboof commented Jun 14, 2024

To make the link to the project-specific security page (which links to the ASF-wide security page, but also adds project-specific information) more prominent.

To make the link to the project-specific security page
(which links to the ASF-wide security page, but also
adds project-specific information) more prominent.
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we removed this link, where can we get security link in seatunnel website page?

@raboof
Copy link
Member Author

raboof commented Jun 18, 2024

This should only remove the 'Security' link in the 'ASF' submenu, not the top-level 'Security' link that points to https://seatunnel.apache.org/security

@Hisoka-X
Copy link
Member

This should only remove the 'Security' link in the 'ASF' submenu, not the top-level 'Security' link that points to https://seatunnel.apache.org/security

Oh, I got it.

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @raboof

@Hisoka-X Hisoka-X merged commit 43257a2 into apache:main Jun 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants