[bugFix][Connector-V2][Doris] The multi-FE configuration is supported #6341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test case for this? |
Ok, I'll add it, but right now I can't find a multi-Fe docker image |
Hisoka-X
reviewed
Apr 25, 2024
| @@ -237,7 +237,8 @@ static String[] parseIdentifier(String tableIdentifier, Logger logger) | |||
| } | |||
|
|
|||
| @VisibleForTesting | |||
| static String randomEndpoint(String feNodes, Logger logger) throws DorisConnectorException { | |||
| public static String randomEndpoint(String feNodes, Logger logger) | |||
There was a problem hiding this comment.
Use UT to test this method is enough.
Hisoka-X
reviewed
May 6, 2024
...r-doris/src/test/java/org/apache/seatunnel/connectors/doris/rest/models/RestServiceTest.java
Outdated
Show resolved
Hide resolved
|
@Hisoka-X cc |
Hisoka-X
reviewed
May 10, 2024
...r-doris/src/test/java/org/apache/seatunnel/connectors/doris/rest/models/RestServiceTest.java
Outdated
Show resolved
Hide resolved
hailin0
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
close #6337
Does this PR introduce any user-facing change?
How was this patch tested?
Current test
Check list
New License Guide
release-note.