Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix][Core] Fix the NullPointException for the json config of the job without pluginname #6815

Merged
merged 2 commits into from
May 11, 2024

Conversation

dailai
Copy link
Contributor

@dailai dailai commented May 9, 2024

Purpose of this pull request

When we use the json config of the job define that without pluginname, this case will throw NullPointerException.
截屏2024-05-09 08 17 40

Like this:
{ "env": { "parallelism": 4, "job.mode": "BATCH" }, "source": [ { "result_table_name": "fake", "row.num": 100, "schema": { "fields": { "name": "string", "age": "int", "card": "int" } } } ], "transform": [ ], "sink": [ { "source_table_name": "fake1" } ] }

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@dailai dailai changed the title [Hotfix][Seatunnel-engine-core] Fix the NullPointException for the json config of the job without pluginname [Hotfix][Core] Fix the NullPointException for the json config of the job without pluginname May 9, 2024
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should check flink and spark job too.

@Hisoka-X Hisoka-X added bug core SeaTunnel core module labels May 9, 2024
@dailai
Copy link
Contributor Author

dailai commented May 9, 2024

I think we should check flink and spark job too.

Yes,

I think we should check flink and spark job too.

That's right. I haven't committed my code yet

@dailai dailai force-pushed the fix-nullpotinerexception-for-job-job branch 5 times, most recently from bae287a to b9826d5 Compare May 10, 2024 01:54
@dailai dailai force-pushed the fix-nullpotinerexception-for-job-job branch from ad97c66 to 3a7214a Compare May 10, 2024 08:56
@dailai dailai requested a review from Hisoka-X May 11, 2024 01:25
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @dailai !

@Hisoka-X Hisoka-X merged commit fc39390 into apache:dev May 11, 2024
15 checks passed
@dailai dailai deleted the fix-nullpotinerexception-for-job-job branch June 13, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants