[Feature][RestAPI] Add overview api #6883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 23, 2024 15:54
Hisoka-X
changed the title
Hisoka-X
reviewed
May 30, 2024
| } | ||
|
|
||
| @Override | ||
| public int workCount() { |
There was a problem hiding this comment.
Suggested change
| public int workCount() { | |
| public int workerCount() { |
| @@ -39,7 +39,7 @@ public static void main(String[] args) | |||
| clientCommandArgs.setJobName(Paths.get(configFile).getFileName().toString()); | |||
| // Change Execution Mode to CLUSTER to use client mode, before do this, you should start | |||
| // SeaTunnelEngineServerExample | |||
| clientCommandArgs.setMasterType(MasterType.LOCAL); | |||
| clientCommandArgs.setMasterType(MasterType.CLUSTER); | |||
There was a problem hiding this comment.
Suggested change
| clientCommandArgs.setMasterType(MasterType.CLUSTER); | |
| clientCommandArgs.setMasterType(MasterType.LOCAL); |
Comment on lines
46
to
76
| List<SlotProfile> assignedSlots = resourceManager.getAssignedSlots(); | ||
|
|
||
| List<SlotProfile> unassignedSlots = resourceManager.getUnassignedSlots(); | ||
| IMap<Long, JobState> finishedJob = | ||
| getNodeEngine().getHazelcastInstance().getMap(Constant.IMAP_FINISHED_JOB_STATE); | ||
| overviewInfo.setTotalSlot(assignedSlots.size() + unassignedSlots.size()); | ||
| overviewInfo.setUnassignedSlot(unassignedSlots.size()); | ||
| overviewInfo.setRunningJobs( | ||
| getNodeEngine() | ||
| .getHazelcastInstance() | ||
| .getMap(Constant.IMAP_RUNNING_JOB_INFO) | ||
| .size()); | ||
| overviewInfo.setFailedJobs( | ||
| finishedJob.values().stream() | ||
| .filter( | ||
| jobState -> | ||
| jobState.getJobStatus() | ||
| .name() | ||
| .equals(JobStatus.FAILED.toString())) | ||
| .count()); | ||
| overviewInfo.setCancelledJobs( | ||
| finishedJob.values().stream() | ||
| .filter( | ||
| jobState -> | ||
| jobState.getJobStatus() | ||
| .name() | ||
| .equals(JobStatus.CANCELED.toString())) | ||
| .count()); | ||
| overviewInfo.setWorks(resourceManager.workCount()); | ||
| overviewInfo.setFinishedJobs( | ||
| finishedJob.values().stream() |
There was a problem hiding this comment.
I find this part show up twice. Please do some refactor.
Hisoka-X
previously approved these changes
May 31, 2024
|
Please fix ci error |
|
|
Hisoka-X
approved these changes
Jun 3, 2024
hailin0
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
{
"projectVersion": "2.3.5",
"gitCommitAbbrev": "DeadD0d0",
"totalSlot": "0",
"unassignedSlot": "0",
"runningJobs": "0",
"finishedJobs": "0",
"failedJobs": "0",
"cancelledJobs": "0",
"works": "1"
}
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.