Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][Paimon] Add check for the base type between source and sink before write. #6953

Merged
merged 3 commits into from
Jun 11, 2024
Merged

[Improve][Paimon] Add check for the base type between source and sink before write. #6953

merged 3 commits into from
Jun 11, 2024

Conversation

dailai
Copy link
Contributor

@dailai dailai commented Jun 6, 2024

Purpose of this pull request

Add check for the base type between source and sink before write.

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@dailai dailai changed the title [Improve][Paimon] Add check for the base type between source and sink [Improve][Paimon] Add check for the base type between source and sink before write. Jun 6, 2024
@dailai dailai force-pushed the hotfix-for-paimon-sink branch 2 times, most recently from 49165a9 to 7b6e4af Compare June 6, 2024 10:05
Hisoka-X
Hisoka-X reviewed Jun 7, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dailai for this PR!

seatunnel-common/src/main/java/org/apache/seatunnel/common/exception/CommonErrorCode.java Outdated Show resolved Hide resolved
seatunnel-common/src/main/java/org/apache/seatunnel/common/exception/CommonError.java Outdated Show resolved Hide resolved
...aimon/src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/utils/RowConverter.java Outdated Show resolved Hide resolved
...e/connector-paimon-e2e/src/test/java/org/apache/seatunnel/e2e/connector/paimon/PaimonIT.java Outdated Show resolved Hide resolved
Hisoka-X
Hisoka-X approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @dailai

@hailin0 hailin0 merged commit d56d64f into apache:dev Jun 11, 2024
4 checks passed
@dailai dailai deleted the hotfix-for-paimon-sink branch June 13, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hailin0 hailin0 hailin0 approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

Assignees
No one assigned
Labels
approved improve paimon reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dailai @hailin0 @Hisoka-X