Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Connector-V2][MongoDB] Support to convert to double from any numeric type #6997

Merged
merged 11 commits into from
Jun 19, 2024

Conversation

loustler
Copy link
Contributor

@loustler loustler commented Jun 17, 2024

Purpose of this pull request

This pull request is support to convert double from numeric type that MongoDB save 5.0 as 5 like int type. It's similar with #6726 in sink side.

Does this PR introduce any user-facing change?

NO

How was this patch tested?

Package the connector-mongo-2.3.5-2.12.15.jar, place it in a docker image, and complete the MongoDB reading test

Check list

@Hisoka-X
Copy link
Member

Thanks @loustler for created this PR! Could you follow the guide to open github action on your fork repository? https://github.com/apache/seatunnel/runs/26296464394

@Hisoka-X
Copy link
Member

How about add a test case in

?

@loustler loustler changed the title [Improve][Connector-V2][MongoDB] Support to convert to double from int stored as int [Improve][Connector-V2][MongoDB] Support to convert to double from any numeric type Jun 18, 2024
@Hisoka-X Hisoka-X added the First-time contributor First-time contributor label Jun 19, 2024
@Hisoka-X
Copy link
Member

image
Oh, please run mvn spotless:apply to fix code style before push commit.

@loustler
Copy link
Contributor Author

loustler commented Jun 19, 2024

@Hisoka-X
Thanks for your support
I've added and formatted a test code

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @loustler for update!

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if ci passed. Thanks @loustler !

@loustler
Copy link
Contributor Author

@Hisoka-X CI passed! Thank you :)

@hailin0 hailin0 merged commit c5159a2 into apache:dev Jun 19, 2024
4 checks passed
@loustler loustler deleted the mongo-convert-double-from-int branch June 19, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants