-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve][Connector-V2][MongoDB] Support to convert to double from any numeric type #6997
Conversation
Thanks @loustler for created this PR! Could you follow the guide to open github action on your fork repository? https://github.com/apache/seatunnel/runs/26296464394 |
How about add a test case in Line 35 in 0c3044e
|
@Hisoka-X |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @loustler for update!
...in/java/org/apache/seatunnel/connectors/seatunnel/mongodb/serde/BsonToRowDataConverters.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if ci passed. Thanks @loustler !
@Hisoka-X CI passed! Thank you :) |
Purpose of this pull request
This pull request is support to convert double from numeric type that MongoDB save
5.0
as5
like int type. It's similar with #6726 in sink side.Does this PR introduce any user-facing change?
NO
How was this patch tested?
Package the connector-mongo-2.3.5-2.12.15.jar, place it in a docker image, and complete the MongoDB reading test
Check list
New License Guide
release-note
.