Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix][MySQL-CDC] Fix read gbk varchar chinese garbled characters #7046

Merged
merged 1 commit into from
Jun 25, 2024
Merged

[Hotfix][MySQL-CDC] Fix read gbk varchar chinese garbled characters #7046

merged 1 commit into from
Jun 25, 2024

Conversation

hailin0
Copy link
Member

@hailin0 hailin0 commented Jun 21, 2024 •
edited
Loading

Purpose of this pull request

[MySQL-CDC] Fix read gbk varchar chinese garbled characters

Does this PR introduce any user-facing change?

No

How was this patch tested?

Check list

hailin0
hailin0 commented Jun 21, 2024
View reviewed changes
...ysql/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/mysql/utils/MySqlUtils.java
@@ -342,44 +334,6 @@ public static SeaTunnelRowType getSplitType(
return getSplitType(primaryKeys.get(0), dbzConnectorConfig);
}

/** Creates a new {@link MySqlDatabaseSchema} to monitor the latest MySql database schemas. */
public static MySqlDatabaseSchema createMySqlDatabaseSchema(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove duplicate methods

...ache/seatunnel/connectors/seatunnel/cdc/mysql/config/CustomMySqlConnectionConfiguration.java
public class CustomMySqlConnectionConfiguration
extends MySqlConnection.MySqlConnectionConfiguration {

protected static final String URL_PATTERN =
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete characterSetResults=UTF-8 from

https://github.com/debezium/debezium/blob/393291bba54edc745f45a679ffd7b2aa7110f454/debezium-connector-mysql/src/main/java/io/debezium/connector/mysql/MySqlConnection.java#L56

@hailin0
Copy link
Member Author

hailin0 commented Jun 21, 2024

image

@hailin0 hailin0 marked this pull request as ready for review June 23, 2024 08:09
Hisoka-X
Hisoka-X approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hisoka-X Hisoka-X linked an issue Jun 24, 2024 that may be closed by this pull request
[Bug] [ZETA] debezium_json Chinese garbled characters #7031
Closed
3 tasks
@Hisoka-X Hisoka-X mentioned this pull request Jun 24, 2024
Closed
3 tasks
@EricJoy2048 EricJoy2048 merged commit 4e4d2b8 into apache:dev Jun 25, 2024
4 checks passed
Thomas-HuWei pushed a commit to zilliztech/seatunnel that referenced this pull request Jul 10, 2024
@hailin0 @Thomas-HuWei
[Hotfix][MySQL-CDC] Fix read gbk varchar chinese garbled characters (a…
38528d6 
…pache#7046)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricJoy2048 EricJoy2048 EricJoy2048 approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

Assignees
No one assigned
Labels
approved bugfix cdc mysql reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] [ZETA] debezium_json Chinese garbled characters
3 participants
@hailin0 @EricJoy2048 @Hisoka-X