From c6b495cdf71eb8a306c2b4d34d2dc5e4a7c2507d Mon Sep 17 00:00:00 2001 From: david6969xin <1045319818@qq.com> Date: Fri, 18 Feb 2022 10:35:51 +0800 Subject: [PATCH 1/2] [SCB-2387] optimize abnormal print information of SwaggerProducerOperation --- .../servicecomb/foundation/common/utils/ExceptionUtils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/ExceptionUtils.java b/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/ExceptionUtils.java index acf0b452fb3..3ad8d5aa683 100644 --- a/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/ExceptionUtils.java +++ b/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/ExceptionUtils.java @@ -18,7 +18,7 @@ package org.apache.servicecomb.foundation.common.utils; public class ExceptionUtils { - private static final int DEPTH = 5; + private static final int DEPTH = 2; private ExceptionUtils() { From 8f5a659c5d34f82b25aa4d1aea08bf0bbc31dae8 Mon Sep 17 00:00:00 2001 From: david6969xin <1045319818@qq.com> Date: Fri, 18 Feb 2022 13:53:35 +0800 Subject: [PATCH 2/2] [SCB-2387] optimize abnormal print information of SwaggerProducerOperation --- .../servicecomb/foundation/common/utils/ExceptionUtils.java | 2 +- .../servicecomb/swagger/engine/SwaggerProducerOperation.java | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/ExceptionUtils.java b/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/ExceptionUtils.java index 3ad8d5aa683..acf0b452fb3 100644 --- a/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/ExceptionUtils.java +++ b/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/ExceptionUtils.java @@ -18,7 +18,7 @@ package org.apache.servicecomb.foundation.common.utils; public class ExceptionUtils { - private static final int DEPTH = 2; + private static final int DEPTH = 5; private ExceptionUtils() { diff --git a/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/engine/SwaggerProducerOperation.java b/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/engine/SwaggerProducerOperation.java index b715abd9576..f348563fbf0 100644 --- a/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/engine/SwaggerProducerOperation.java +++ b/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/engine/SwaggerProducerOperation.java @@ -22,7 +22,6 @@ import java.util.concurrent.CompletableFuture; -import org.apache.servicecomb.foundation.common.utils.ExceptionUtils; import org.apache.servicecomb.foundation.common.utils.SPIServiceUtils; import org.apache.servicecomb.swagger.invocation.AsyncResponse; import org.apache.servicecomb.swagger.invocation.Response; @@ -153,7 +152,7 @@ public void doCompletableFutureInvoke(SwaggerInvocation invocation, AsyncRespons } catch (Throwable e) { if (shouldPrintErrorLog(e)) { LOGGER.error("unexpected error operation={}, message={}", - invocation.getInvocationQualifiedName(), ExceptionUtils.getExceptionMessageWithoutTrace(e)); + invocation.getInvocationQualifiedName(), e.getMessage()); } invocation.onBusinessMethodFinish(); invocation.onBusinessFinish(); @@ -186,7 +185,7 @@ public Response doInvoke(SwaggerInvocation invocation) { } catch (Throwable e) { if (shouldPrintErrorLog(e)) { LOGGER.error("unexpected error operation={}, message={}", - invocation.getInvocationQualifiedName(), ExceptionUtils.getExceptionMessageWithoutTrace(e)); + invocation.getInvocationQualifiedName(), e.getMessage()); } invocation.onBusinessMethodFinish(); invocation.onBusinessFinish();