diff --git a/foundations/foundation-metrics/src/main/java/io/servicecomb/foundation/metrics/performance/MetricsDataMonitor.java b/foundations/foundation-metrics/src/main/java/io/servicecomb/foundation/metrics/performance/MetricsDataMonitor.java index afe7054cc90..33abe73cd39 100644 --- a/foundations/foundation-metrics/src/main/java/io/servicecomb/foundation/metrics/performance/MetricsDataMonitor.java +++ b/foundations/foundation-metrics/src/main/java/io/servicecomb/foundation/metrics/performance/MetricsDataMonitor.java @@ -69,9 +69,8 @@ public MetricsDataMonitor() { * @return QueueMetrics object based on key */ public QueueMetricsData getOrCreateQueueMetrics(String pathId) { - return queueMetrics.computeIfAbsent(pathId, p -> { - return new QueueMetricsData(); - }); + return queueMetrics.computeIfAbsent(pathId, p -> new QueueMetricsData() + ); } /** @@ -86,10 +85,10 @@ public Map getQueueMetrics() { /** * Returns the map of average values for both instance and operational level. * - * @return queue metrics map + * @param newMap the new map which passed to queue metrics */ - public Map setQueueMetrics(Map newMap) { - return queueMetrics = newMap; + public void setQueueMetrics(Map newMap) { + queueMetrics = newMap; } /** @@ -120,6 +119,7 @@ public void incrementTotalReqProvider() { /** * Sets the total requests per provider. + * @param totalReqProvider the total requests per provider */ public void setTotalReqProvider(Long totalReqProvider) { this.totalReqProvider = totalReqProvider; @@ -143,6 +143,7 @@ public void incrementTotalFailReqProvider() { /** * Sets the total failed requests per provider. + * @param totalFailedReqProvider the total failed requests per provider */ public void setTotalFailReqProvider(Long totalFailedReqProvider) { this.totalFailReqProvider = totalFailedReqProvider; @@ -166,6 +167,7 @@ public void incrementTotalReqConsumer() { /** * Sets the total failed requests per consumer. + * @param totalReqConsumer the total requests per consumer */ public void setTotalReqConsumer(Long totalReqConsumer) { this.totalReqConsumer = totalReqConsumer; @@ -189,6 +191,7 @@ public void incrementTotalFailReqConsumer() { /** * Sets the total failed requests per consumer. + * @param totalFailedReqConsumer the total failed requests per consumer */ public void setTotalFailReqConsumer(Long totalFailedReqConsumer) { this.totalFailReqConsumer = totalFailedReqConsumer; diff --git a/foundations/foundation-metrics/src/main/java/io/servicecomb/foundation/metrics/performance/MetricsDataMonitorUtil.java b/foundations/foundation-metrics/src/main/java/io/servicecomb/foundation/metrics/performance/MetricsDataMonitorUtil.java index d7959222104..17dbfb60f77 100644 --- a/foundations/foundation-metrics/src/main/java/io/servicecomb/foundation/metrics/performance/MetricsDataMonitorUtil.java +++ b/foundations/foundation-metrics/src/main/java/io/servicecomb/foundation/metrics/performance/MetricsDataMonitorUtil.java @@ -24,7 +24,7 @@ */ public final class MetricsDataMonitorUtil { - /** + /* * Sets the total requests per provider and consumer. */ public void setAllReqProviderAndConsumer(String operationPath, String invocationType) { @@ -39,7 +39,7 @@ public void setAllReqProviderAndConsumer(String operationPath, String invocation } } - /** + /* * Sets the total failed requests per provider and consumer. */ public void setAllFailReqProviderAndConsumer(String operationPath, String invocationType) { diff --git a/foundations/foundation-metrics/src/main/java/io/servicecomb/foundation/metrics/performance/QueueMetricsData.java b/foundations/foundation-metrics/src/main/java/io/servicecomb/foundation/metrics/performance/QueueMetricsData.java index 81a536afc47..e196bc0edad 100644 --- a/foundations/foundation-metrics/src/main/java/io/servicecomb/foundation/metrics/performance/QueueMetricsData.java +++ b/foundations/foundation-metrics/src/main/java/io/servicecomb/foundation/metrics/performance/QueueMetricsData.java @@ -199,16 +199,14 @@ public void setMaxLifeTimeInQueue(long maxLifeTimeInQueue) { } /** - * Sets minimum lifetime in queue. - * @param maxLifeTimeInQueue maximum lifetime + * Resets minimum lifetime in queue. */ public void resetMinLifeTimeInQueue() { this.minLifeTimeInQueue = 0L; } /** - * resets maximum lifetime in queue. - * @param maxLifeTimeInQueue maximum lifetime + * Resets maximum lifetime in queue. */ public void resetMaxLifeTimeInQueue() { this.maxLifeTimeInQueue = 0L;