[SCB-252] Overwatch Integration#531
Closed
zhengyangyong wants to merge 9 commits into
Closed
Conversation
added 6 commits
January 26, 2018 09:09
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
added 2 commits
January 26, 2018 10:39
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
liubao68
reviewed
Jan 31, 2018
|
|
||
| @Component | ||
| public class MetricsBootListener implements BootListener { | ||
| private static final Logger logger = LoggerFactory.getLogger(MetricsBootListener.class); |
Contributor
There was a problem hiding this comment.
For conventions, better to use LOGGER
liubao68
reviewed
Jan 31, 2018
|
|
||
| public OverwatchMetricsPublisher(HealthCheckerManager checkerManager) { | ||
| this.checkerManager = checkerManager; | ||
| String url = "http://" + DynamicPropertyFactory.getInstance() |
Contributor
There was a problem hiding this comment.
publisher should be full customize by developers, including schema(https), and certificates etc.
liubao68
reviewed
Jan 31, 2018
| @Component | ||
| public class MetricsPublisher implements ApplicationListener<ApplicationEvent> { | ||
| private static final Logger LOGGER = LoggerFactory.getLogger(MetricsPublisher.class); | ||
| private static final Logger logger = LoggerFactory.getLogger(MetricsPublisher.class); |
Contributor
There was a problem hiding this comment.
why changed to logger? for static final varibles, use upper case, see this code below(METRICS_PROMETHEUS_PORT).
…l path config Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean installto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.Integration with Overwatch
Also samples "metrics-overwatch-sample"