[SCB-311] Support Record Custom Metrics in Java Chassis Itself#535
[SCB-311] Support Record Custom Metrics in Java Chassis Itself#535zhengyangyong wants to merge 1 commit into
Conversation
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
|
current custom metric mechanism maybe not good, i will do some test first, and then confirm this PR. |
WillemJiang
left a comment
There was a problem hiding this comment.
It looks like a refactoring that reuses the customer metric for the other module.
What about the old implementation, I don't see the move changes in the PR.
@zhengyangyong do you have any plan to remove old implementation?
|
No , I only extend Events let developers can raise 'Record Custom Metrics Event' same as Java Chassis raise 'Invocation Event' mechanism,so no any move changes in the PR. |
|
I don't think we need remove old implementation,direct use CounterService,GaugeService and WindowCounterService record custom metrics may more efficient and friendly than raise event,this mechanism is only recommend for 'Java Chassis Developer' |
|
chassis are metrics's customers |
Signed-off-by: zhengyangyong yangyong.zheng@huawei.com
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean installto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.