Skip to content

[SCB-311] Support Record Custom Metrics in Java Chassis Itself#535

Closed
zhengyangyong wants to merge 1 commit into
apache:masterfrom
zhengyangyong:SCB-311
Closed

[SCB-311] Support Record Custom Metrics in Java Chassis Itself#535
zhengyangyong wants to merge 1 commit into
apache:masterfrom
zhengyangyong:SCB-311

Conversation

@zhengyangyong
Copy link
Copy Markdown

@zhengyangyong zhengyangyong commented Jan 26, 2018

Signed-off-by: zhengyangyong yangyong.zheng@huawei.com

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 87.3% when pulling 51cfddd on zhengyangyong:SCB-311 into 8e84b30 on apache:master.

@wujimin
Copy link
Copy Markdown
Contributor

wujimin commented Jan 27, 2018

current custom metric mechanism maybe not good, i will do some test first, and then confirm this PR.

Copy link
Copy Markdown
Member

@WillemJiang WillemJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a refactoring that reuses the customer metric for the other module.

What about the old implementation, I don't see the move changes in the PR.
@zhengyangyong do you have any plan to remove old implementation?

@zhengyangyong
Copy link
Copy Markdown
Author

No , I only extend Events let developers can raise 'Record Custom Metrics Event' same as Java Chassis raise 'Invocation Event' mechanism,so no any move changes in the PR.
Becuase metrics is a Optional module and Java Chassis can't direct autowire CounterService,GaugeService and WindowCounterService in metrics-core.

@zhengyangyong
Copy link
Copy Markdown
Author

I don't think we need remove old implementation,direct use CounterService,GaugeService and WindowCounterService record custom metrics may more efficient and friendly than raise event,this mechanism is only recommend for 'Java Chassis Developer'

@wujimin
Copy link
Copy Markdown
Contributor

wujimin commented Jan 29, 2018

chassis are metrics's customers
chassis's customers and chassis should use the same mechanism.

@zhengyangyong zhengyangyong deleted the SCB-311 branch March 27, 2018 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants