[SCB-327] Update metrics publish data module#550
Closed
zhengyangyong wants to merge 18 commits into
Closed
Conversation
liubao68
approved these changes
Feb 8, 2018
zhengyangyong
force-pushed
the
SCB-327
branch
from
8f4fb45 to
72b6b33
Compare
Author
|
Rebase and resolved conflicts |
WillemJiang
reviewed
Feb 9, 2018
| tps.increment(); | ||
| } | ||
|
|
||
| public Map<String, Double> measure(int windowTimeIndex) { |
Member
There was a problem hiding this comment.
Do we still need to support window time here?
Author
There was a problem hiding this comment.
I think we may remove this feature later
WillemJiang
reviewed
Feb 9, 2018
| this.appliedWindowTimes.put(appliedWindowTimes.get(i), i); | ||
|
|
||
| List<Long> sortedPollingSettings = Lists.newArrayList(parsePollingSettings); | ||
| System.getProperties().setProperty("servo.pollers", Strings.join(",", sortedPollingSettings.iterator())); |
Member
There was a problem hiding this comment.
It's not good way to set the system properties here (as it could be overridden anytime), can we setup the servo poller directly?
Author
There was a problem hiding this comment.
it seems servo read and parse this setting use System.getPropert;
Could not find another way yet.
added 9 commits
February 10, 2018 08:37
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
…h code (200,500... etc) Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
wujimin
reviewed
Feb 11, 2018
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| public class Metric { |
Contributor
There was a problem hiding this comment.
why wrap another class?
Metric just equals Measurement......
Author
There was a problem hiding this comment.
we do not import spectator in current version;
this class had parse metric output id into name and tag map,easy use for grouping
wujimin
reviewed
Feb 11, 2018
| package org.apache.servicecomb.metrics.common; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Map; |
Contributor
There was a problem hiding this comment.
common move to foundation-metrics
Author
There was a problem hiding this comment.
metrics-common had deleted and move all content into foundation-metrics
wujimin
reviewed
Feb 11, 2018
| * @return RegistryMetric | ||
| */ | ||
| RegistryMetric metricsWithWindowTime(long windowTime); | ||
| Map<String, Double> metrics(); |
Contributor
There was a problem hiding this comment.
why we need this interface?
…foundation-metrics Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
zhengyangyong
force-pushed
the
SCB-327
branch
from
1c06e50 to
977a4ef
Compare
added 8 commits
February 11, 2018 13:13
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
…n-metrics Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
…er to prevent low-probability test failed on ci Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean installto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.adjust metrics publish format to spring cloud netflix style
Before:
servicecomb.instance.system.cpu.load
servicecomb.instance.system.cpu.runningThreads
servicecomb.instance.system.heap.init
servicecomb.instance.system.heap.max
servicecomb.instance.system.heap.commit
servicecomb.instance.system.heap.used
servicecomb.instance.system.nonHeap.init
servicecomb.instance.system.nonHeap.max
servicecomb.instance.system.nonHeap.commit
servicecomb.instance.system.nonHeap.used
servicecomb.instance | operationName.producer.waitInQueue.count
servicecomb.instance | operationName.producer.lifeTimeInQueue.average
servicecomb.instance | operationName.producer.lifeTimeInQueue.max
servicecomb.instance | operationName.producer.lifeTimeInQueue.min
servicecomb.instance | operationName.producer.executionTime.average
servicecomb.instance | operationName.producer.executionTime.max
servicecomb.instance | operationName.producer.executionTime.min
servicecomb.instance | operationName.producer.producerLatency.average
servicecomb.instance | operationName.producer.producerLatency.max
servicecomb.instance | operationName.producer.producerLatency.min
servicecomb.instance | operationName.producer.producerCall.total
servicecomb.instance | operationName.producer.producerCall.tps
servicecomb.instance | operationName.consumer.consumerLatency.average
servicecomb.instance | operationName.consumer.consumerLatency.max
servicecomb.instance | operationName.consumer.consumerLatency.min
servicecomb.instance | operationName.consumer.consumerCall.total
servicecomb.instance | operationName.consumer.consumerCall.tps
Current:
jvm(statistic=gauge,name={name})
{name} include :
cpuLoad,cpuRunningThreads,heapInit,heapMax,heapCommit,
heapUsed,nonHeapInit,nonHeapMax,nonHeapCommit,nonHeapUsed
servicecomb.invocation(operation={operationName},role={role},stage={stage},statistic={statistic},status={status})
A output sample:
