SCB-373 change Rest args code/encoding to HttpClientFilter/HttpServer…#578
Merged
Conversation
wujimin
approved these changes
Mar 9, 2018
liubao68
approved these changes
Mar 9, 2018
wujimin
reviewed
Mar 9, 2018
| try { | ||
| RestCodec.argsToRest(invocation.getArgs(), swaggerRestOperation, restClientRequest); | ||
| requestEx.setBodyBuffer(restClientRequest.getBodyBuffer()); | ||
| } catch (Exception e) { |
Contributor
There was a problem hiding this comment.
it's better to catch throwable
wujimin
reviewed
Mar 9, 2018
| produceProcessor.encodeResponse(output, body); | ||
|
|
||
| responseEx.setBodyBuffer(output.getBuffer()); | ||
| } catch (Exception e) { |
Contributor
There was a problem hiding this comment.
it's better to catch throwable
Contributor
Author
There was a problem hiding this comment.
yes, i'll repair this
|
If user direct invoke rest producer by explorer, explorer will try to get favicon first,then producer will throw an null point exception |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Filter，so some body can do something through writing other Filters around args coding
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean installto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.