[SCB-1398] add project in uri path, modify related api to support the change #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianxiaoliang
requested changes
Aug 9, 2019
client/client.go
Outdated
| url := fmt.Sprintf("%s/%s/%s", c.opts.Endpoint, APIPathKV, kv.Key) | ||
| func (c *Client) Put(ctx context.Context, kv model.KVDoc, project string) (*model.KVDoc, error) { | ||
| finalPath := fmt.Sprintf("%s/%s/%s", version, project, APIPathKV) | ||
| url := fmt.Sprintf("%s/%s/%s", c.opts.Endpoint, finalPath, kv.Key) |
There was a problem hiding this comment.
fmt.Sprintf is graceful, but it has poor performance, never use it in func that handles a lots of data
1. add project field in KVDoc and LabelDoc, add the param for project in backend api 2. all related mongo CRUD should add filter for project
tianxiaoliang
requested changes
Aug 12, 2019
client/client.go
Outdated
| @@ -81,8 +82,9 @@ func New(config Config) (*Client, error) { | |||
| } | |||
|
|
|||
| //Put create value of a key | |||
| func (c *Client) Put(ctx context.Context, kv model.KVDoc) (*model.KVDoc, error) { | |||
| url := fmt.Sprintf("%s/%s/%s", c.opts.Endpoint, APIPathKV, kv.Key) | |||
| func (c *Client) Put(ctx context.Context, kv model.KVDoc, project string) (*model.KVDoc, error) { | |||
There was a problem hiding this comment.
project is an option， default value is "default"
client/client.go
Outdated
| @@ -113,12 +115,13 @@ func (c *Client) Put(ctx context.Context, kv model.KVDoc) (*model.KVDoc, error) | |||
| } | |||
|
|
|||
| //Get get value of a key | |||
| func (c *Client) Get(ctx context.Context, key string, opts ...GetOption) ([]*model.KVDoc, error) { | |||
| func (c *Client) Get(ctx context.Context, key string, project string, opts ...GetOption) ([]*model.KVDoc, error) { | |||
There was a problem hiding this comment.
project is an option， default value is "default"
client/client.go
Outdated
| @@ -147,8 +150,9 @@ func (c *Client) Get(ctx context.Context, key string, opts ...GetOption) ([]*mod | |||
| } | |||
|
|
|||
| //Delete remove kv | |||
| func (c *Client) Delete(ctx context.Context, kvID, labelID string) error { | |||
| url := fmt.Sprintf("%s/%s/?kvID=%s", c.opts.Endpoint, APIPathKV, kvID) | |||
| func (c *Client) Delete(ctx context.Context, kvID, labelID string, project string) error { | |||
There was a problem hiding this comment.
project is an delete option， default value is "default"
client/client.go
Outdated
| @@ -35,7 +35,7 @@ import ( | |||
|
|
|||
| //const | |||
| const ( | |||
| APIPathKV = "v1/kv" | |||
| APIPathKV = "v1/test/kie/kv" | |||
liuqi04
force-pushed
the
tmp
branch
4 times, most recently
from
31a4a60
to
03a9dbc
Compare
tianxiaoliang
requested changes
Aug 13, 2019
| @@ -70,6 +71,11 @@ func (r *KVResource) GetByKey(context *restful.Context) { | |||
| WriteErrResponse(context, http.StatusForbidden, "key must not be empty", common.ContentTypeText) | |||
| return | |||
| } | |||
| project := context.ReadPathParameter("project") | |||
tianxiaoliang
approved these changes
Aug 14, 2019
liuqi04
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SCB-1398]