Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Janusgraph OSGi bundle #109

Closed
wants to merge 2 commits into from

Conversation

@CMoH
Copy link
Contributor

commented Nov 27, 2017

Add a OSGi bundle for janusgraph-core. The goal is to be able to access janusgraph servers remotely from OSGi environments. I've added an example at https://github.com/CMoH/tinkerpop-osgi-samples on how this bundle is usable to connect to a remote server.

Also added OSGi bundle for gremlin-driver-3.2.6, since it is a dependency of janusgraph-core-0.2.0

@jbonofre

This comment has been minimized.

Copy link
Member

commented Nov 27, 2017

@jbonofre
Copy link
Member

left a comment

The main pom.xml is not updated. Remember to add those bundles in order to be included in next release cycle.

</parent>

<groupId>org.apache.servicemix.bundles</groupId>
<artifactId>org.apache.servicemix.bundles.gremlin-driver-shaded</artifactId>

This comment has been minimized.

Copy link
@jbonofre

jbonofre Nov 28, 2017

Member

Why shaded ? We should simply use gremlin-driver IMHO.

</parent>

<groupId>org.apache.servicemix.bundles</groupId>
<artifactId>org.apache.servicemix.bundles.janusgraph-core-shaded</artifactId>

This comment has been minimized.

Copy link
@jbonofre

jbonofre Nov 28, 2017

Member

Same here, why shaded ? The artifactId is already unique.

@CMoH

This comment has been minimized.

Copy link
Contributor Author

commented Nov 28, 2017

Thanks for the review - I'll make the necessary changes and rebase

@jbonofre

This comment has been minimized.

Copy link
Member

commented Nov 28, 2017

Awesome, thank you so much !

@CMoH CMoH force-pushed the CMoH:janusgraph branch 2 times, most recently from 2934441 to a0a385b Nov 28, 2017

@CMoH CMoH force-pushed the CMoH:janusgraph branch from a0a385b to 260cc4c Nov 28, 2017

@CMoH

This comment has been minimized.

Copy link
Contributor Author

commented Nov 28, 2017

@jbonofre I believe the PR is again ready for a review

@jbonofre
Copy link
Member

left a comment

LGTM, Thanks, I will merge !

@jbonofre

This comment has been minimized.

Copy link
Member

commented Nov 29, 2017

By the way, I will create the corresponding Jira and update the commits.

@asfgit asfgit closed this in 41f096b Nov 29, 2017

@CMoH

This comment has been minimized.

Copy link
Contributor Author

commented Nov 29, 2017

Thank you very much!

@CMoH CMoH deleted the CMoH:janusgraph branch Dec 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.