Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SM-3712 Create OSGi bundle for Thymeleaf 3.0.7 #124

Closed
wants to merge 1 commit into from

Conversation

@oliverlietz
Copy link
Member

commented May 19, 2018

No description provided.

@oscerd
oscerd approved these changes May 20, 2018
@oscerd

This comment has been minimized.

Copy link
Contributor

commented May 20, 2018

Is there a specific reason to have bundles from 3.0.0 to 3.0.9? Usually we release the last one available, but if you have a reason for this it's fine for me

@oliverlietz

This comment has been minimized.

Copy link
Member Author

commented May 20, 2018

@oscerd, the reason is to have fully transparent and reproducible package versions (properly calculated by bnd). Usually bundles from SM export packages using the library version.

@oscerd

This comment has been minimized.

Copy link
Contributor

commented May 20, 2018

@jbonofre wdyt here?

@jbonofre

This comment has been minimized.

Copy link
Member

commented May 21, 2018

The bundle should provide the version (not bnd). So, -1 to have all those bundles, only latest one is enough.

Copy link
Member

left a comment

Disapprove: only latest version makes sense. Please close this PR.

@oliverlietz

This comment has been minimized.

Copy link
Member Author

commented May 21, 2018

@jbonofre, I disagree here and prefer bundles with proper versioned packages. Is there a policy at SM that says bundle has to provide version? Why do we have servicemix.osgi.export and servicemix.osgi.export.pkg at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.