Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor MonitorService #872

Merged
merged 1 commit into from Jul 1, 2020
Merged

Refactor MonitorService #872

merged 1 commit into from Jul 1, 2020

Conversation

Technoboy-
Copy link
Contributor

@Technoboy- Technoboy- commented Jun 30, 2020 •
edited

Fixes #782.

Changes proposed in this pull request:

  • Add monitor tag to configure MonitorService.
  • Remove monitor configuration from job attribute.
  • Update some test case.

Comments:

  1. After this pr, we could config monitor service like below:
<monitor:embed id="monitor1" registry-center-ref="regCenter" monitor-port="9999"/>
  1. Dump job data with below command:
dump@jobName
  1. Documents will be updated later in other pr.

@Technoboy- Technoboy- closed this Jul 1, 2020
@Technoboy- Technoboy- reopened this Jul 1, 2020
@terrymanu terrymanu added this to the 3.0.0 milestone Jul 1, 2020
@terrymanu terrymanu merged commit 2ceb8a7 into apache:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.0.0-alpha
Development

Successfully merging this pull request may close these issues.

Refactor MonitorService
2 participants
@Technoboy- @terrymanu