Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor usage of ConcurrentHashMap in DriverExecutionPrepareEngine #13275

Merged
merged 1 commit into from Oct 26, 2021
Merged

Refactor usage of ConcurrentHashMap in DriverExecutionPrepareEngine #13275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 16 additions & 1 deletion ...apache/shardingsphere/infra/executor/sql/prepare/driver/DriverExecutionPrepareEngine.java
View file
Open in desktop
Expand Up @@ -62,7 +62,22 @@ public DriverExecutionPrepareEngine(final String type, final int maxConnectionsS
super(maxConnectionsSizePerQuery, rules);
this.executorDriverManager = executorDriverManager;
this.option = option;
sqlExecutionUnitBuilder = TYPE_TO_BUILDER_MAP.computeIfAbsent(type, key -> TypedSPIRegistry.getRegisteredService(SQLExecutionUnitBuilder.class, key, new Properties()));
sqlExecutionUnitBuilder = getCachedSqlExecutionUnitBuilder(type);
}

/**
* Refer to https://bugs.openjdk.java.net/browse/JDK-8161372.
*
* @param type type
* @return sql execution unit builder
*/
@SuppressWarnings("rawtypes")
private SQLExecutionUnitBuilder getCachedSqlExecutionUnitBuilder(final String type) {
SQLExecutionUnitBuilder result;
if (null == (result = TYPE_TO_BUILDER_MAP.get(type))) {
result = TYPE_TO_BUILDER_MAP.computeIfAbsent(type, key -> TypedSPIRegistry.getRegisteredService(SQLExecutionUnitBuilder.class, key, new Properties()));
}
return result;
}

@Override
Expand Down