Restore client modules for JDK 8 split baseline#9
Merged
Conversation
The split client repository needs to carry MCP registration, beat registration, Spring Boot starters, and discovery registration without inheriting the main repository JDK upgrade constraints. This restores the client-side module surface on the JDK 8 release base, rebases dependencies onto Spring Boot 2/JDK 8 compatible lines, and expands CI coverage through JDK 25 after local compatibility verification. Constraint: Client artifacts must remain JDK 8 compatible while validating JDK 17, 21, 23, and 25 Constraint: The split repository does not define the release Maven profile, so CI uses ./mvnw -B clean test Rejected: Move the client back under the main repository | it would keep client compatibility tied to admin/bootstrap JDK upgrade timing Rejected: Keep JDK 23 and 25 as local-only checks | CI would not catch future toolchain regressions Confidence: medium Scope-risk: broad Directive: Do not upgrade client runtime dependencies without rerunning the JDK 8 compatibility build Tested: ./mvnw -DskipTests compile Tested: ./mvnw test Tested: JAVA_HOME=/Library/Java/JavaVirtualMachines/zulu-8.jdk/Contents/Home ./mvnw -B clean test Tested: JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/corretto-17.0.13/Contents/Home ./mvnw -B clean test -Prelease Tested: JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home ./mvnw -B clean test -Prelease Tested: JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-25.0.2/Contents/Home ./mvnw -B clean test Tested: JAVA_HOME=/tmp/shenyu-jdks/jdk-23.0.2+7/Contents/Home ./mvnw -B clean test Not-tested: End-to-end registration against matching admin/bootstrap runtime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compatibility Notes
./mvnw -B clean testbecause this split repository does not define the oldreleaseMaven profile.Verification
./mvnw -DskipTests compile./mvnw testJAVA_HOME=$(/usr/libexec/java_home -v 1.8) ./mvnw -B clean testJAVA_HOME=$(/usr/libexec/java_home -v 17) ./mvnw -B clean test -PreleaseJAVA_HOME=$(/usr/libexec/java_home -v 21) ./mvnw -B clean test -PreleaseJAVA_HOME=$(/usr/libexec/java_home -v 25) ./mvnw -B clean testJAVA_HOME=/tmp/shenyu-jdks/jdk-23.0.2+7/Contents/Home ./mvnw -B clean test.github/workflows/ci.ymlYAML parsing passedRemaining Risk