Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical link, LOG invoke method, causing performance loss. #4387

Merged
merged 4 commits into from
Feb 16, 2023

Conversation

iwangjie
Copy link
Contributor

@iwangjie iwangjie commented Feb 15, 2023

Synchronous invocation methods should not be used in LOG invocations of critical links, which can affect performance.

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2023

Codecov Report

Merging #4387 (f338a4e) into master (97e10af) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #4387      +/-   ##
============================================
+ Coverage     68.36%   68.38%   +0.01%     
+ Complexity     7515     7513       -2     
============================================
  Files          1020     1020              
  Lines         28813    28813              
  Branches       2568     2568              
============================================
+ Hits          19699    19704       +5     
+ Misses         7578     7574       -4     
+ Partials       1536     1535       -1     
Impacted Files Coverage Δ
...yu/plugin/httpclient/AbstractHttpClientPlugin.java 40.00% <100.00%> (ø)
...henyu/common/cache/MemorySafeWindowTinyLFUMap.java 81.66% <0.00%> (+8.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@li-keguo li-keguo merged commit 962277f into apache:master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants