Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4540] Added service test cases for admin #4579

Merged
merged 4 commits into from
Apr 23, 2023

Conversation

sachin10fi
Copy link
Contributor

@sachin10fi sachin10fi commented Apr 22, 2023

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@sachin10fi
Copy link
Contributor Author

@moremind Hello, common.cache.MemorySafeWindowTinyLFUMapTest.testWindowTinyLFU UT is failing in the build for some reason, I didn't make any changes to that file and it is passing in local

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2023

Codecov Report

Merging #4579 (4445d75) into master (9f602df) will increase coverage by 0.54%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4579      +/-   ##
============================================
+ Coverage     68.85%   69.39%   +0.54%     
- Complexity     7746     7791      +45     
============================================
  Files          1033     1033              
  Lines         29609    29609              
  Branches       2682     2682              
============================================
+ Hits          20386    20546     +160     
+ Misses         7617     7447     -170     
- Partials       1606     1616      +10     

see 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@moremind moremind merged commit 5c2760f into apache:master Apr 23, 2023
yu199195 pushed a commit to yu199195/shenyu that referenced this pull request May 5, 2023
* Added Service Test Cases

* Fixing Style Issues

---------

Co-authored-by: likeguo <33576070+li-keguo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants