Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:tcp nacos sync #4657

Merged
merged 12 commits into from
May 25, 2023
Merged

feat:tcp nacos sync #4657

merged 12 commits into from
May 25, 2023

Conversation

mahaitao617
Copy link
Contributor

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2023

Codecov Report

Attention: Patch coverage is 23.18841% with 53 lines in your changes missing coverage. Please review.

Project coverage is 66.92%. Comparing base (e37b730) to head (2498096).
Report is 491 commits behind head on master.

Files with missing lines Patch % Lines
...dmin/listener/AbstractListDataChangedListener.java 6.25% 45 Missing ⚠️
...nyu/sync/data/nacos/handler/NacosCacheHandler.java 54.54% 5 Missing ⚠️
...nyu/admin/listener/DataChangedEventDispatcher.java 0.00% 2 Missing ⚠️
...che/shenyu/admin/listener/DataChangedListener.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4657      +/-   ##
============================================
- Coverage     67.13%   66.92%   -0.21%     
+ Complexity     8014     8004      -10     
============================================
  Files          1099     1099              
  Lines         31695    31758      +63     
  Branches       2872     2874       +2     
============================================
- Hits          21277    21253      -24     
- Misses         8745     8828      +83     
- Partials       1673     1677       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yu199195 yu199195 added this to the 2.6.0 milestone May 25, 2023
@yu199195 yu199195 merged commit f3aa857 into apache:master May 25, 2023
@mahaitao617 mahaitao617 deleted the mht_tcp_518 branch May 25, 2023 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants