Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type:feat] add springcloud cache #4705

Merged
merged 6 commits into from
Jun 7, 2023

Conversation

moremind
Copy link
Member

@moremind moremind commented Jun 6, 2023

Fixes #4680

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@moremind moremind changed the title Springcloud cache [type:feat] add springcloud cache Jun 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Merging #4705 (1193887) into master (846ec64) will decrease coverage by 0.07%.
The diff coverage is 23.07%.

@@             Coverage Diff              @@
##             master    #4705      +/-   ##
============================================
- Coverage     66.34%   66.28%   -0.07%     
  Complexity     8011     8011              
============================================
  Files          1109     1111       +2     
  Lines         32117    32166      +49     
  Branches       2904     2906       +2     
============================================
+ Hits          21308    21321      +13     
- Misses         9118     9151      +33     
- Partials       1691     1694       +3     
Impacted Files Coverage Δ
...he/shenyu/plugin/base/cache/CommonHandleCache.java 77.77% <0.00%> (-9.73%) ⬇️
...ngcloud/listener/SpringCloudHeartBeatListener.java 0.00% <0.00%> (ø)
...plugin/springcloud/cache/ServiceInstanceCache.java 20.00% <20.00%> (ø)
.../org/apache/shenyu/common/config/ShenyuConfig.java 67.59% <33.33%> (-0.89%) ⬇️
...d/loadbalance/ShenyuSpringCloudServiceChooser.java 80.95% <33.33%> (-4.05%) ⬇️
...ingcloud/handler/SpringCloudPluginDataHandler.java 80.48% <40.00%> (-13.27%) ⬇️
...in/springcloud/SpringCloudPluginConfiguration.java 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@moremind moremind added this to the 2.6.0 milestone Jun 6, 2023
@loongs-zhang loongs-zhang self-requested a review June 6, 2023 14:44
@loongs-zhang loongs-zhang merged commit 23aa4f6 into apache:master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] SpringCloudLocalCache task
3 participants