Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix api document module update api detail error #4720

Merged
merged 3 commits into from
Jun 9, 2023
Merged

bugfix api document module update api detail error #4720

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac393cb
bugfix api document module update api detail error
tomsun28 Jun 9, 2023
197757c
Merge branch 'master' into bugfix-api-doc-update
loongs-zhang Jun 9, 2023
34b7274
Merge branch 'master' into bugfix-api-doc-update
loongs-zhang Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/ApiServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ private String update(final ApiDTO apiDTO) {
.id(UUIDUtils.getInstance().generateShortUuid())
.apiId(apiDO.getId())
.tagId(tagId)
.dateCreated(currentTime)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the SQL statement, changing the create time in the update interface is incorrect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the SQL statement, changing the create time in the update interface is incorrect.

  tagRelationMapper.deleteByApiId(apiDO.getId());
  tagRelationMapper.batchInsert(tags);

hi, but due the tag relation always be deleted and then insert new tag relation when update this api, the createdTime always is currentTime.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I saw that.

.dateUpdated(currentTime)
.build()).collect(Collectors.toList());
tagRelationMapper.deleteByApiId(apiDO.getId());
Expand Down