Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4687] shenyu-sdk-spring test case. #4913

Merged
merged 10 commits into from
Jul 28, 2023
Merged

[ISSUE #4687] shenyu-sdk-spring test case. #4913

merged 10 commits into from
Jul 28, 2023

Conversation

damonxue
Copy link
Contributor

@damonxue damonxue commented Jul 27, 2023

#4538

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

Codecov Report

Merging #4913 (4ac138d) into master (3ab7df0) will increase coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 80.95%.

@@             Coverage Diff              @@
##             master    #4913      +/-   ##
============================================
+ Coverage     64.04%   64.06%   +0.01%     
- Complexity     8312     8439     +127     
============================================
  Files          1180     1195      +15     
  Lines         34867    35368     +501     
  Branches       3115     3203      +88     
============================================
+ Hits          22331    22658     +327     
- Misses        10763    10868     +105     
- Partials       1773     1842      +69     
Files Changed Coverage Δ
...ng/annotation/RequestHeaderParameterProcessor.java 73.07% <42.85%> (ø)
...ing/annotation/RequestParamParameterProcessor.java 86.36% <80.00%> (ø)
...ing/annotation/PathVariableParameterProcessor.java 88.00% <88.88%> (ø)
...ache/shenyu/sdk/spring/ShenyuClientsRegistrar.java 66.04% <100.00%> (ø)
...ring/annotation/CookieValueParameterProcessor.java 94.11% <100.00%> (ø)

... and 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@damonxue
Copy link
Contributor Author

pls review. @moremind

@yu199195 yu199195 merged commit c39afff into apache:master Jul 28, 2023
39 checks passed
@damonxue damonxue deleted the issue_4538_sdk_test branch July 28, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants