Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tensor naming convention review #570

Merged
merged 9 commits into from Jan 18, 2020
Merged

Tensor naming convention review #570

merged 9 commits into from Jan 18, 2020

Conversation

dcslin
Copy link
Member

@dcslin dcslin commented Dec 23, 2019

  1. added additional word to indicate mutation on underline data
  2. add inplace flag to indicate mutation on underline data
  3. updated cpp sum() on axis
  4. no change to python add_column() or similar as it could be done by broadcast and could be deprecated.

nudles
nudles reviewed Jan 1, 2020
View reviewed changes
python/singa/tensor.py Show resolved Hide resolved
python/singa/tensor.py Show resolved Hide resolved
@dcslin
Copy link
Member Author

dcslin commented Jan 13, 2020

Hi @nudles, thanks for the review, this is ready for merge.

@nudles nudles merged commit 2c78e39 into apache:master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nudles nudles nudles left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dcslin @nudles