From aad66cca0ddad0bbf2a6c4bbded5187892a601d1 Mon Sep 17 00:00:00 2001 From: Kui LIU Date: Sun, 22 Apr 2018 09:47:25 +0200 Subject: [PATCH] Change the method name "toString" to "appendString". The method is named "toString", actually, it just appends new data to the variable 'buffer'. To differentiate it from the override "toString" method and make it more intuitive, the method should be renamed "appendString". --- .../src/main/java/org/apache/sis/metadata/TreeNode.java | 4 ++-- .../main/java/org/apache/sis/metadata/TreeNodeChildren.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/core/sis-metadata/src/main/java/org/apache/sis/metadata/TreeNode.java b/core/sis-metadata/src/main/java/org/apache/sis/metadata/TreeNode.java index 6377fb1b812..a5bc386a67b 100644 --- a/core/sis-metadata/src/main/java/org/apache/sis/metadata/TreeNode.java +++ b/core/sis-metadata/src/main/java/org/apache/sis/metadata/TreeNode.java @@ -897,14 +897,14 @@ public final boolean isEditable(final TableColumn column) { @Override public final String toString() { final StringBuilder buffer = new StringBuilder(60); - toString(buffer); + appendString(buffer); return buffer.toString(); } /** * Implementation of {@link #toString()} appending the string representation in the given buffer. */ - final void toString(final StringBuilder buffer) { + final void appendString(final StringBuilder buffer) { appendIdentifier(buffer.append("Node[")); buffer.append(" : ").append(Classes.getShortName(baseType)).append(']'); } diff --git a/core/sis-metadata/src/main/java/org/apache/sis/metadata/TreeNodeChildren.java b/core/sis-metadata/src/main/java/org/apache/sis/metadata/TreeNodeChildren.java index 811045788cc..9f522ef67e6 100644 --- a/core/sis-metadata/src/main/java/org/apache/sis/metadata/TreeNodeChildren.java +++ b/core/sis-metadata/src/main/java/org/apache/sis/metadata/TreeNodeChildren.java @@ -614,11 +614,11 @@ final boolean add(final int index, final Object value) throws IllegalStateExcept public String toString() { final String lineSeparator = System.lineSeparator(); final StringBuilder buffer = new StringBuilder(512); - parent.toString(buffer); + parent.appendString(buffer); buffer.append(lineSeparator); for (final TreeTable.Node node : this) { buffer.append(" "); - ((TreeNode) node).toString(buffer); + ((TreeNode) node).appendString(buffer); buffer.append(lineSeparator); } return buffer.toString();