From 8eabef3c2a249bb0f07c9ad666d98b682143f43c Mon Sep 17 00:00:00 2001 From: Tomasz Pytel Date: Fri, 20 Nov 2020 13:16:58 -0300 Subject: [PATCH] Fix: Span.tag() for overridable --- skywalking/trace/span.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/skywalking/trace/span.py b/skywalking/trace/span.py index 53c36c736..75157bf79 100644 --- a/skywalking/trace/span.py +++ b/skywalking/trace/span.py @@ -91,10 +91,12 @@ def tag(self, tag: Tag) -> 'Span': self.tags.append(deepcopy(tag)) return self - for t in self.tags: + for i, t in enumerate(self.tags): if t.key == tag.key: - t.val = tag.val + self.tags[i] = deepcopy(tag) break + else: + self.tags.append(deepcopy(tag)) return self