Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [BanyanDB] Metrics breaks periodically #12312

Closed
2 of 3 tasks
wu-sheng opened this issue Jun 9, 2024 · 4 comments · Fixed by #12321
Closed
2 of 3 tasks

[Bug] [BanyanDB] Metrics breaks periodically #12312

wu-sheng opened this issue Jun 9, 2024 · 4 comments · Fixed by #12321
Assignees
Labels
bug Something isn't working and you are sure it's a bug! database BanyanDB - SkyWalking native database demo env Relate to http://demo.skywalking.apache.org

Comments

@wu-sheng
Copy link
Member

wu-sheng commented Jun 9, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

Apache SkyWalking Component

BanyanDB (apache/skywalking-banyandb)

What happened

Since we switched demo database to BanyanDB, most things work well, but I noticed this kind of metric breaking.

image

Meanwhile, this only happens on minute level,

image

All services/pods of demo env seem normal

image

But we noticed this error happens periodically too in the OAP pod logs.

image

I also checked the BanyanDB client codes, although we don't expose the configuration to BanyanDB provider(@lujiajing1126 we should expose), but the default value is 50m.
But this error log says, ~5m. So, @hanahmily @lujiajing1126 @ButterBright Is the server missing the configurations? And could you check whether there is other reason to make metrics breaking.

What you expected to happen

Make metrics continuously flush into the storage.

How to reproduce

I didn't reproduce this, but observe this on demo env.

Anything else

No response

Are you willing to submit a pull request to fix on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

@wu-sheng wu-sheng added bug Something isn't working and you are sure it's a bug! database BanyanDB - SkyWalking native database labels Jun 9, 2024
@wu-sheng wu-sheng added this to the BanyanDB - 0.7.0 milestone Jun 9, 2024
@Superskyyy
Copy link
Member

Seems like a client side problem, the 50MB didn't take effect.

@wu-sheng
Copy link
Member Author

wu-sheng commented Jun 9, 2024

I didn't check that deeply. But it seems existing in the default constructor. Doesn't it?

@hanahmily
Copy link
Contributor

I checked the client, and it seems that the error cannot be from the BanyanDB client.

image

The error is related to the 'getCompressedBody' function, but the client should always use the 'getUncompressedBody' instead. BTW, maxInboundMessageSize is 50MB even though the client doesn't use it here.

@wu-sheng wu-sheng added the demo env Relate to http://demo.skywalking.apache.org label Jun 9, 2024
@wu-sheng
Copy link
Member Author

wu-sheng commented Jun 9, 2024

@wankai123 Let us bump up otel collectoe first. This seems irrelevant with DB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working and you are sure it's a bug! database BanyanDB - SkyWalking native database demo env Relate to http://demo.skywalking.apache.org
Projects
None yet
5 participants