Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the test coverage rate #2438

Open
wu-sheng opened this issue Apr 3, 2019 · 7 comments

Comments

@wu-sheng
Copy link
Member

commented Apr 3, 2019

Today, SkyWalking's tests are mostly around integration tests, which are benifit for end users. Now we hope through this, people from community could help on Unit Tests.

JUnit and Mockito are provided. This is a good start for everyone wants to contribute codes. When you submit test cases PR, please ref to this issue.

@wu-sheng wu-sheng added the help wanted label Apr 3, 2019
@wu-sheng wu-sheng pinned this issue Apr 3, 2019
@wu-sheng wu-sheng changed the title Increase the test coverage Increase the test coverage rate Apr 3, 2019
@wu-sheng

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2019

Also, in this kind of pull request, we don't limit how many test cases you provide. Even one new test case, which could effectively test one more line, it will be acceptable. Just try your best to make tests more sense.

@flycash

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

Where can I find the code coverage report?

@wu-sheng

This comment has been minimized.

Copy link
Member Author

commented Apr 23, 2019

@wu-sheng wu-sheng referenced this issue Apr 30, 2019
1 of 4 tasks complete
@SataQiu SataQiu referenced this issue May 8, 2019
0 of 3 tasks complete
@wu-sheng

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2019

Update here, we are only just increasing the test case coverage, we are doing more.

  • @kezhenxu94 set up the Jenkins of ASF for power test env.
  • @ascrutae lead the agent test in Jenkins jobs of every PR when necessary
  • @kezhenxu94 lead the e2e test, make agent/backend integration test done in every PR.
@wu-sheng

This comment has been minimized.

Copy link
Member Author

commented Jul 22, 2019

We have e2e tests fro single node w/ H2 and cluster mode w/ ES. We are trying to build more. Including MySQL storage tests, alarm tests, and aggregation accuracy tests.

@wu-sheng

This comment has been minimized.

Copy link
Member Author

commented Oct 6, 2019

After #3561, we have 30%+ coverage now.

@wu-sheng

This comment has been minimized.

Copy link
Member Author

commented Oct 6, 2019

@ascrutae lead the agent test in Jenkins jobs of every PR when necessary

This task is lead by @dmsolr on #3528. Ownership replaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.