Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can skywalking support brpc-java tracing? #2661

Open
wenweihu86 opened this issue May 14, 2019 · 6 comments

Comments

@wenweihu86
Copy link

commented May 14, 2019

Please answer these questions before submitting your issue.

  • Why do you submit this issue?
    I want to use skywaling with brpc-java.
    https://github.com/baidu/brpc-java

  • Question or discussion
    discussion

  • Bug
    no

  • Requirement
    yes

  • Feature or performance improvement
    Feature


Question

  • What do you want to know?

Bug

  • Which version of SkyWalking, OS and JRE?

  • Which company or project?
    www.baidu.com

  • What happen?
    If possible, provide a way for reproducing the error. e.g. demo application, component version.


Requirement or improvement

  • Please describe about your requirements or improvement suggestions.
@wu-sheng

This comment has been minimized.

Copy link
Member

commented May 14, 2019

Yes. You could contribute plugin to support brpc-java

@wu-sheng wu-sheng modified the milestone: 6.2.0 May 14, 2019
@IanCao IanCao self-assigned this May 14, 2019
@IanCao

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

@wenweihu86 because of brf's some bugs, i'll open a new pr about skywalking supporting brpc after the new version of brpc releases.

please ping me at that time
Thank you

@wenweihu86

This comment has been minimized.

Copy link
Author

commented May 15, 2019

@IanCao brpc-java 2.3.7 has released.

@IanCao

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

@IanCao brpc-java 2.3.7 has released.

ok

@wenweihu86

This comment has been minimized.

Copy link
Author

commented Aug 14, 2019

what is the process?

@wu-sheng

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

No update. No one submit any pull request related to this. I think you should ask brpc team to help, rather than here. @wenweihu86 We don't know who are using brpc-java.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.