Add HBase client plugin#2539
Closed
shingle2302 wants to merge 20 commits into
Closed
Conversation
Member
|
Why close？ |
Author
|
this plugin has not be tested,click error, wait a few days when i test it.
…------------------ 原始邮件 ------------------
发件人: "于玉桔"<notifications@github.com>;
发送时间: 2019年4月26日(星期五) 晚上10:33
收件人: "apache/skywalking"<skywalking@noreply.github.com>;
抄送: "675953827"<675953827@qq.com>; "State change"<state_change@noreply.github.com>;
主题: Re: [apache/skywalking] 增加HBase插件 (#2539)
Why close？
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Member
Feel free to leave it open to let others know that you're working on it :) |
Member
|
And change title and description in English, please. |
Author
|
ok， I will open it again.
…------------------ 原始邮件 ------------------
发件人: "kezhenxu94"<notifications@github.com>;
发送时间: 2019年4月26日(星期五) 晚上11:02
收件人: "apache/skywalking"<skywalking@noreply.github.com>;
抄送: "675953827"<675953827@qq.com>; "State change"<state_change@noreply.github.com>;
主题: Re: [apache/skywalking] 增加HBase插件 (#2539)
this plugin has not be tested,click error, wait a few days when i test it.
…
Feel free to leave it open to let others know that you're working on it :)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Member
|
After your local test passed. You need to submit test case to here https://github.com/SkyAPMTest/agent-auto-integration-testcases You could find the document there too. |
Author
|
ok，thank you
…------------------ 原始邮件 ------------------
发件人: "吴晟 Wu Sheng"<notifications@github.com>;
发送时间: 2019年4月26日(星期五) 晚上11:16
收件人: "apache/skywalking"<skywalking@noreply.github.com>;
抄送: "675953827"<675953827@qq.com>; "State change"<state_change@noreply.github.com>;
主题: Re: [apache/skywalking] Add HBase client plugin (#2539)
After your local test passed.
You need to submit test case to here https://github.com/SkyAPMTest/agent-auto-integration-testcases
You could find the document there too.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Author
|
I test it locally,but the component on ui and peer is empty,i think i should need more time to test it . |
added 2 commits
April 27, 2019 12:50
Author
|
|
Member
|
Why close? Need a new one? |
Author
|
At this moment, I have no idea to support hbase-client2.x's async api，and the 1.x's test is not complete.
…------------------ 原始邮件 ------------------
发件人: "吴晟 Wu Sheng"<notifications@github.com>;
发送时间: 2019年5月5日(星期天) 晚上7:39
收件人: "apache/skywalking"<skywalking@noreply.github.com>;
抄送: "675953827"<675953827@qq.com>; "State change"<state_change@noreply.github.com>;
主题: Re: [apache/skywalking] Add HBase client plugin (#2539)
Why close? Need a new one?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Member
|
You could choose. This isn't requirement that you must support both. Is 1.0 plugin still ongoing? |
Author
|
I'm learning docker and how to build a hbase image.
…------------------ 原始邮件 ------------------
发件人: "吴晟 Wu Sheng"<notifications@github.com>;
发送时间: 2019年5月6日(星期一) 晚上7:56
收件人: "apache/skywalking"<skywalking@noreply.github.com>;
抄送: "675953827"<675953827@qq.com>; "State change"<state_change@noreply.github.com>;
主题: Re: [apache/skywalking] Add HBase client plugin (#2539)
You could choose. This isn't requirement that you must support both. Is 1.0 plugin still ongoing?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Member
|
I think hbase should have official docker image and docker-compose. Does it? |
Author
|
There is no an offical image from apache,I found some image,but it does not work well.
…------------------ 原始邮件 ------------------
发件人: "吴晟 Wu Sheng"<notifications@github.com>;
发送时间: 2019年5月6日(星期一) 晚上8:47
收件人: "apache/skywalking"<skywalking@noreply.github.com>;
抄送: "675953827"<675953827@qq.com>; "State change"<state_change@noreply.github.com>;
主题: Re: [apache/skywalking] Add HBase client plugin (#2539)
I think hbase should have official docker image and docker-compose. Does it?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting pull request
Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues
Bug fix
Bug description.
How to fix?
New feature or improvement